Fix UserData not being found when added to a project - #293
Open
bddvlpr wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes cloudstack_user_data read behavior when the user data is registered under a CloudStack project by ensuring the read lookup includes project_id, preventing “not found” results from global-only searches.
Changes:
- Include
project_idinListUserDataparameters during resource read. - Add a guard for empty
ListUserDataresults to avoid indexing into an empty slice.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bddvlpr
force-pushed
the
fix/user-data-in-project
branch
from
July 10, 2026 12:29
f7be625 to
4c879d8
Compare
bddvlpr
force-pushed
the
fix/user-data-in-project
branch
from
July 31, 2026 09:05
4c879d8 to
f3f0ab2
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
cloudstack/resource_cloudstack_user_data.go:142
- PR description says that if ListUserData succeeds but returns no entries, the provider should throw an error. This new branch instead logs and clears the resource ID (treating it as deleted), which changes behavior and can cause Terraform to silently “forget” an existing user data if the API returns an empty list unexpectedly. Please either update the PR description to match the intended ‘treat as deleted’ behavior, or change this branch to return an explicit error when zero results are returned.
if len(userdata.UserData) == 0 {
log.Printf("[DEBUG] User data %s no longer exists", id)
d.SetId("")
return nil
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a user data resource is nested in a particular project using project_id, a global search will not find that particular user data.
If for some reason (as the case before),the userdata list command succeeds but doesn't contain any user data itself, throw an error for that.
Reproduce bug